-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
root page decouple #1443
Merged
Merged
root page decouple #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 80.75% | 2777/3439 |
🟡 | Branches | 61.99% | 1755/2831 |
🟡 | Functions | 74.12% | 487/657 |
🟢 | Lines | 81.37% | 2586/3178 |
Test suite run success
400 tests passing in 41 suites.
Report generated by 🧪jest coverage report action from 3e468d3
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
dinhlongviolin1
requested review from
FredLL-Avaiga and
FabienLelaquais
and removed request for
FredLL-Avaiga
June 25, 2024 04:12
dinhlongviolin1
added
🖰 GUI
Related to GUI
🟥 Priority: Critical
Must be addressed as soon as possible
💥Malfunction
Addresses an identified problem.
labels
Jun 25, 2024
FabienLelaquais
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
FredLL-Avaiga
approved these changes
Jun 25, 2024
dinhlongviolin1
added a commit
that referenced
this pull request
Jun 27, 2024
* root page decouple * fix resource_handler id
dinhlongviolin1
added a commit
that referenced
this pull request
Jun 27, 2024
* navigate and download only for the browser window that requests it (#1336) * navigate and download only for the browser window that requests it resolves #1145 * linter --------- Co-authored-by: Fred Lefévère-Laoide <[email protected]> * Get Routes with type frontend decouple (#1370) * Feature/wsadapter (#1423) (#1391) * WS adapter * revert bundle * add taipy designer entry * extract bundle * use ws adapter properly * export wssendmessage * dont export main app -> reduce bundle size * ws message type to include string in d.ts * manage external ws message * add msg_type * export correctly * per Fred * per Fabien * root page decouple (#1443) * root page decouple * fix resource_handler id * fix decouple metadata (#1446) * fix decouple metadata * per Fred + refactor * per Fred * fix decouple metadata (#1446) * fix decouple metadata * per Fred + refactor * per Fred * Fix linter --------- Co-authored-by: Fred Lefévère-Laoide <[email protected]> Co-authored-by: Fred Lefévère-Laoide <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🖰 GUI
Related to GUI
💥Malfunction
Addresses an identified problem.
🟥 Priority: Critical
Must be addressed as soon as possible
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Avaiga/taipy-designer#128, Avaiga/taipy-designer#144