Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root page decouple #1443

Merged
merged 2 commits into from
Jun 25, 2024
Merged

root page decouple #1443

merged 2 commits into from
Jun 25, 2024

Conversation

dinhlongviolin1
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 commented Jun 24, 2024

Related to Avaiga/taipy-designer#128, Avaiga/taipy-designer#144

Copy link
Contributor

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 61.99222889438361%

St.
Category Percentage Covered / Total
🟢 Statements 80.75% 2777/3439
🟡 Branches 61.99% 1755/2831
🟡 Functions 74.12% 487/657
🟢 Lines 81.37% 2586/3178

Test suite run success

400 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from 3e468d3

Copy link
Contributor

github-actions bot commented Jun 24, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18460 16084 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/custom/_page.py 55% 🟢
taipy/gui/gui.py 81% 🟢
TOTAL 68% 🟢

updated for commit: 0e4e130 by action🐍

@dinhlongviolin1 dinhlongviolin1 requested review from FredLL-Avaiga and FabienLelaquais and removed request for FredLL-Avaiga June 25, 2024 04:12
@dinhlongviolin1 dinhlongviolin1 self-assigned this Jun 25, 2024
@dinhlongviolin1 dinhlongviolin1 added 🖰 GUI Related to GUI 🟥 Priority: Critical Must be addressed as soon as possible 💥Malfunction Addresses an identified problem. labels Jun 25, 2024
@dinhlongviolin1 dinhlongviolin1 marked this pull request as ready for review June 25, 2024 04:12
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

taipy/gui/gui.py Show resolved Hide resolved
@dinhlongviolin1 dinhlongviolin1 merged commit 013faf9 into develop Jun 25, 2024
62 of 66 checks passed
@dinhlongviolin1 dinhlongviolin1 deleted the fix/root-page-decouple branch June 25, 2024 12:21
dinhlongviolin1 added a commit that referenced this pull request Jun 27, 2024
* root page decouple

* fix resource_handler id
dinhlongviolin1 added a commit that referenced this pull request Jun 27, 2024
* navigate and download only for the browser window that requests it (#1336)

* navigate and download only for the browser window that requests it
resolves #1145

* linter

---------

Co-authored-by: Fred Lefévère-Laoide <[email protected]>

* Get Routes with type frontend decouple (#1370)

* Feature/wsadapter (#1423) (#1391)

* WS adapter

* revert bundle

* add taipy designer entry

* extract bundle

* use ws adapter properly

* export wssendmessage

* dont export main app -> reduce bundle size

* ws message type to include string in d.ts

* manage external ws message

* add msg_type

* export correctly

* per Fred

* per Fabien

* root page decouple (#1443)

* root page decouple

* fix resource_handler id

* fix decouple metadata (#1446)

* fix decouple metadata

* per Fred + refactor

* per Fred

* fix decouple metadata (#1446)

* fix decouple metadata

* per Fred + refactor

* per Fred

* Fix linter

---------

Co-authored-by: Fred Lefévère-Laoide <[email protected]>
Co-authored-by: Fred Lefévère-Laoide <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants