Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrate_cli): ensure connection is closed #1449

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

joaoandre-avaiga
Copy link
Collaborator

No description provided.

@joaoandre-avaiga joaoandre-avaiga force-pushed the feature/#416-migrate-sql-cli-failing-test branch from d36f72c to cb4d0ec Compare June 25, 2024 23:43
Copy link
Contributor

github-actions bot commented Jun 25, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18467 16085 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/_entity/_migrate/_migrate_sql.py 50% 🟢
TOTAL 50% 🟢

updated for commit: cb4d0ec by action🐍

@trgiangdo trgiangdo linked an issue Jun 26, 2024 that may be closed by this pull request
@trgiangdo trgiangdo added the 💥Malfunction Addresses an identified problem. label Jun 26, 2024
Copy link
Member

@trgiangdo trgiangdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@joaoandre-avaiga joaoandre-avaiga merged commit 0f6e8cc into develop Jun 28, 2024
153 checks passed
@joaoandre-avaiga joaoandre-avaiga deleted the feature/#416-migrate-sql-cli-failing-test branch June 28, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥Malfunction Addresses an identified problem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - Restore migrated entities on SQL test is failing on Windows
3 participants