use taipy-assets favicon #1453
Merged
use taipy-assets favicon #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredLL-Avaiga
added
🟥 Priority: Critical
FredLL-Avaiga
requested review from
namnguyen20999,
dinhlongviolin1 and
FabienLelaquais
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 80.49% (-0.24% 🔻) |
2780/3454 |
| 🟡 | Branches | 61.77% (-0.85% 🔻) |
1755/2841 |
| 🟡 | Functions | 73.79% (-0.53% 🔻) |
487/660 |
| 🟢 | Lines | 81.08% (-0.28% 🔻) |
2588/3192 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / Dialog.tsx |
80.43% | 60.87% | 100% | 80.43% |
| 🟡 | ... / TaipyRendered.tsx |
64.58% | 14.29% | 50% | 64.58% |
| 🟡 | ... / index.ts |
75.51% | 26.67% | 50% | 75% |
| 🟢 | ... / Expandable.tsx |
100% | 85% | 100% | 100% |
| 🟢 | ... / PageContent.tsx |
75% | 100% | 0% | 100% |
| 🟢 | ... / Pane.tsx |
95.12% | 73.81% | 100% | 94.87% |
| 🟢 | ... / Part.tsx |
88% | 64.29% | 75% | 91.3% |
| 🟡 | ... / Unregistered.tsx |
62.5% | 0% | 0% | 60% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟡 | ... / taipyReducers.ts |
64.18% (-0.69% 🔻) |
56.61% (-1.86% 🔻) |
42.86% | 63.56% (-0.82% 🔻) |
| 🔴 | context/utils.ts | 55% (-45% 🔻) |
50% (-20% 🔻) |
40% (-60% 🔻) |
43.75% (-56.25% 🔻) |
Test suite run success
400 tests passing in 41 suites.
Report generated by 🧪jest coverage report action from 8d3cc27
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
added 2 commits
June 27, 2024 10:41
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 80.49% (-0.24% 🔻) |
2780/3454 |
| 🟡 | Branches | 61.77% (-0.85% 🔻) |
1755/2841 |
| 🟡 | Functions | 73.79% (-0.53% 🔻) |
487/660 |
| 🟢 | Lines | 81.08% (-0.28% 🔻) |
2588/3192 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / Dialog.tsx |
80.43% | 60.87% | 100% | 80.43% |
| 🟡 | ... / TaipyRendered.tsx |
64.58% | 14.29% | 50% | 64.58% |
| 🟡 | ... / index.ts |
75.51% | 26.67% | 50% | 75% |
| 🟢 | ... / Expandable.tsx |
100% | 85% | 100% | 100% |
| 🟢 | ... / PageContent.tsx |
75% | 100% | 0% | 100% |
| 🟢 | ... / Pane.tsx |
95.12% | 73.81% | 100% | 94.87% |
| 🟢 | ... / Part.tsx |
88% | 64.29% | 75% | 91.3% |
| 🟡 | ... / Unregistered.tsx |
62.5% | 0% | 0% | 60% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟡 | ... / taipyReducers.ts |
64.18% (-0.69% 🔻) |
56.61% (-1.86% 🔻) |
42.86% | 63.56% (-0.82% 🔻) |
| 🔴 | context/utils.ts | 55% (-45% 🔻) |
50% (-20% 🔻) |
40% (-60% 🔻) |
43.75% (-56.25% 🔻) |
Test suite run success
400 tests passing in 41 suites.
Report generated by 🧪jest coverage report action from 6adf7c5
added 2 commits
June 27, 2024 11:59
namnguyen20999
pushed a commit
that referenced
this pull request
Jul 8, 2024
* use taipy-assets favicon resolves #1327 allow to change favicon dynamically resolves #1244 * with doc * doc * test * Fab's comments * allow to change favicon for one state * fab's comments * favicon * mypy * trying to fix cross-env ... * trying to fix cross-env ... * trying to fix cross-env ... * do not run test if cache hit * noncoverage either if cache hit * class name --------- Co-authored-by: Fred Lefévère-Laoide <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1327
allow to change favicon dynamically
resolves #1244
gui.set_favicon("https://raw.githubusercontent.com/Avaiga/taipy-assets/develop/favicon-3.1.png")state.set_favicon("https://raw.githubusercontent.com/Avaiga/taipy-assets/develop/favicon-3.1.png")gui.set_favicon("https://raw.githubusercontent.com/Avaiga/taipy-assets/develop/favicon-3.1.png", state)