Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose websocket decouple frontend #1501

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Conversation

dinhlongviolin1
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented Jul 11, 2024

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 63.32644628099173%

St.
Category Percentage Covered / Total
🟢 Statements 81.7% 2876/3520
🟡 Branches 63.33% 1839/2904
🟡 Functions 75.44% 510/676
🟢 Lines 82.44% 2681/3252

Test suite run success

427 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from 1892a9c

Copy link
Contributor

github-actions bot commented Jul 11, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19269 16361 85% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 1892a9c by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

FredLL-Avaiga
FredLL-Avaiga previously approved these changes Jul 11, 2024
frontend/taipy-gui/base/src/app.ts Show resolved Hide resolved
@dinhlongviolin1
Copy link
Member Author

added a comment execution function for all exposed callbacks

FredLL-Avaiga
FredLL-Avaiga previously approved these changes Jul 11, 2024
frontend/taipy-gui/base/src/app.ts Show resolved Hide resolved
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frontend/taipy-gui/base/src/app.ts Show resolved Hide resolved
frontend/taipy-gui/base/src/app.ts Show resolved Hide resolved
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@dinhlongviolin1 dinhlongviolin1 merged commit 87065e1 into develop Jul 15, 2024
155 of 159 checks passed
@dinhlongviolin1 dinhlongviolin1 deleted the feature/decouple-ws-status branch July 15, 2024 16:26
dinhlongviolin1 added a commit that referenced this pull request Jul 15, 2024
* Expose websocket decouple frontend

* add useEvent per Fred

* per Fred and Fabien
dinhlongviolin1 added a commit that referenced this pull request Jul 16, 2024
* Expose websocket decouple frontend

* add useEvent per Fred

* per Fred and Fabien
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants