Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases for FileSelector.tsx #1507

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

namnguyen20999
Copy link
Member

Test Coverage Progress File % Stmts % Branch % Funcs % Lines Uncovered Line #s
⌛ Before FileSelector.tsx 64.28 45 30.76 63.76 37-39,71-85,96,102-104,110-111,116-124
✅ After FileSelector.tsx 100 92.5 100 100 73,106-121

@namnguyen20999 namnguyen20999 self-assigned this Jul 11, 2024
@namnguyen20999 namnguyen20999 added 🧪Testing Related to tests and other QA activities. GUI: Front-End 📈 Improvement Improvement of a feature. labels Jul 11, 2024
Copy link
Contributor

github-actions bot commented Jul 11, 2024

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 63.32644628099173%

St.
Category Percentage Covered / Total
🟢 Statements
81.7% (+0.71% 🔼)
2876/3520
🟡 Branches
63.33% (-0% 🔻)
1839/2904
🟡 Functions
75.44% (+1.14% 🔼)
510/676
🟢 Lines
82.44% (+0.76% 🔼)
2681/3252
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
64.58% 14.29% 50% 64.58%
🟡
... / index.ts
75.51% 26.67% 50% 75%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
62.5% 0% 0% 60%

Test suite run success

427 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from c2fa848

Copy link
Contributor

github-actions bot commented Jul 11, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19269 16361 85% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: c2fa848 by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😯

Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try and remove the getByTestId ?

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@namnguyen20999 namnguyen20999 dismissed FredLL-Avaiga’s stale review July 12, 2024 18:46

resolved all comments

@namnguyen20999 namnguyen20999 merged commit 1e9c8a1 into develop Jul 12, 2024
156 of 159 checks passed
@namnguyen20999 namnguyen20999 deleted the test/fileSelector branch July 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 📈 Improvement Improvement of a feature. 🧪Testing Related to tests and other QA activities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants