Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table edit default behavior #1530

Merged
merged 21 commits into from
Jul 17, 2024

Conversation

FredLL-Avaiga
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga commented Jul 16, 2024

resolves #557
resolves #1488

import pandas as pd

from taipy.gui import Gui


def get_table():
    dic = {"key": [1,2,3], "Value":[3,4,5]}
    return pd.DataFrame(dic)

table = get_table()
page_content = """
<|{table}|table|show_all|editable|not on_add|>
"""

pages = {"content": page_content}

gui = Gui(pages=pages)
gui.run(title="557 Table default edit")

Fred Lefévère-Laoide added 2 commits July 16, 2024 20:49
@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI 📝Release Notes Impacts the Release Notes or the Documentation in general labels Jul 16, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Jul 16, 2024
Copy link
Contributor

github-actions bot commented Jul 16, 2024

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 65.23383768913342%

St.
Category Percentage Covered / Total
🟢 Statements
82.92% (-0.16% 🔻)
2917/3518
🟡 Branches
65.23% (-0.78% 🔻)
1897/2908
🟡 Functions
77.51% (-0.37% 🔻)
524/676
🟢 Lines
83.5% (-0.17% 🔻)
2713/3249
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
64.58% 14.29% 50% 64.58%
🟡
... / index.ts
75.51% 26.67% 50% 75%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
62.5% 0% 0% 60%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / TableFilter.tsx
93.33% (-0.16% 🔻)
74.76% (+1.42% 🔼)
88.89%
93.86% (-0.16% 🔻)
🟡
... / AutoLoadingTable.tsx
74.05%
50.56% (-0.84% 🔻)
61.36% 75.14%

Test suite run success

466 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 6ebdf82

Copy link
Contributor

github-actions bot commented Jul 16, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19346 16400 85% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/_renderers/builder.py 83% 🟢
taipy/gui/_renderers/factory.py 96% 🟢
taipy/gui/data/data_accessor.py 73% 🟢
taipy/gui/data/pandas_data_accessor.py 65% 🟢
taipy/gui/gui.py 81% 🟢
taipy/gui/utils/table_col_builder.py 63% 🟢
TOTAL 77% 🟢

updated for commit: 71e8d31 by action🐍

Copy link
Contributor

github-actions bot commented Jul 17, 2024

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 65.20991052993807%

St.
Category Percentage Covered / Total
🟢 Statements 82.92% 2918/3519
🟡 Branches 65.21% 1895/2906
🟡 Functions 77.51% 524/676
🟢 Lines 83.51% 2714/3250

Test suite run success

466 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from e733607

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

taipy/gui/_renderers/factory.py Outdated Show resolved Hide resolved
taipy/gui/_renderers/factory.py Outdated Show resolved Hide resolved
taipy/gui/_renderers/factory.py Outdated Show resolved Hide resolved
taipy/gui/data/pandas_data_accessor.py Outdated Show resolved Hide resolved
.github/workflows/frontend.yml Show resolved Hide resolved
.github/workflows/frontend.yml Outdated Show resolved Hide resolved
FredLL-Avaiga and others added 4 commits July 17, 2024 13:30
Co-authored-by: Fabien Lelaquais <[email protected]>
Co-authored-by: Fabien Lelaquais <[email protected]>
Co-authored-by: Fabien Lelaquais <[email protected]>
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@namnguyen20999 namnguyen20999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FredLL-Avaiga FredLL-Avaiga merged commit 69280fa into develop Jul 17, 2024
161 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#557-table-edit-default-behavior branch July 17, 2024 14:44
@bobbyshermi
Copy link
Contributor

Thank you for implementing this. That's great.

A few questions, based on the example you gave:
<|{table}|table|show_all|editable|not on_add|>

  1. By default, the table is not editable, right?
  2. What is the not on_add property? What is its default behavior and the default values for each column?

Thanx

@FredLL-Avaiga
Copy link
Member Author

Replies in the issue #557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Coverage report is failing Default behaviors of edit, add, and delete for tables
5 participants