-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table edit default behavior #1530
table edit default behavior #1530
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 82.92% (-0.16% 🔻) |
2917/3518 |
🟡 | Branches | 65.23% (-0.78% 🔻) |
1897/2908 |
🟡 | Functions | 77.51% (-0.37% 🔻) |
524/676 |
🟢 | Lines | 83.5% (-0.17% 🔻) |
2713/3249 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | ... / Dialog.tsx |
80.43% | 60.87% | 100% | 80.43% |
🟡 | ... / TaipyRendered.tsx |
64.58% | 14.29% | 50% | 64.58% |
🟡 | ... / index.ts |
75.51% | 26.67% | 50% | 75% |
🟢 | ... / Expandable.tsx |
100% | 85% | 100% | 100% |
🟢 | ... / PageContent.tsx |
75% | 100% | 0% | 100% |
🟢 | ... / Pane.tsx |
95.12% | 73.81% | 100% | 94.87% |
🟢 | ... / Part.tsx |
88% | 64.29% | 75% | 91.3% |
🟡 | ... / Unregistered.tsx |
62.5% | 0% | 0% | 60% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | ... / TableFilter.tsx |
93.33% (-0.16% 🔻) |
74.76% (+1.42% 🔼) |
88.89% | 93.86% (-0.16% 🔻) |
🟡 | ... / AutoLoadingTable.tsx |
74.05% | 50.56% (-0.84% 🔻) |
61.36% | 75.14% |
Test suite run success
466 tests passing in 42 suites.
Report generated by 🧪jest coverage report action from 6ebdf82
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 82.92% | 2918/3519 |
🟡 | Branches | 65.21% | 1895/2906 |
🟡 | Functions | 77.51% | 524/676 |
🟢 | Lines | 83.51% | 2714/3250 |
Test suite run success
466 tests passing in 42 suites.
Report generated by 🧪jest coverage report action from e733607
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Fabien Lelaquais <[email protected]>
Co-authored-by: Fabien Lelaquais <[email protected]>
Co-authored-by: Fabien Lelaquais <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for implementing this. That's great. A few questions, based on the example you gave:
Thanx |
Replies in the issue #557 |
resolves #557
resolves #1488