Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inactive file selector #1533

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

FredLL-Avaiga
Copy link
Member

resolves #1532

from taipy.gui import Gui

filename = ""
page = """
<|{filename}|file_selector|not active|>
"""

gui = Gui(page=page)
gui.run(title="1532 Inactive File selector")

@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 💥Malfunction Addresses an identified problem. GUI: Front-End labels Jul 16, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Jul 16, 2024
Copy link
Contributor

github-actions bot commented Jul 16, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19285 16375 85% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f6c5ac9 by action🐍

Copy link
Contributor

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 64.83138334480385%

St.
Category Percentage Covered / Total
🟢 Statements
82.82% (-0.13% 🔻)
2917/3522
🟡 Branches
64.83% (-0.75% 🔻)
1884/2906
🟡 Functions
77.37% (-0.36% 🔻)
523/676
🟢 Lines
83.43% (-0.15% 🔻)
2713/3252
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
64.58% 14.29% 50% 64.58%
🟡
... / index.ts
75.51% 26.67% 50% 75%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
62.5% 0% 0% 60%

Test suite run success

457 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from f6c5ac9

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that was an interesting and unexpected fix...

@FredLL-Avaiga FredLL-Avaiga merged commit cfd0d77 into develop Jul 17, 2024
157 of 159 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#1532-inactive-file-selector branch July 17, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] inactive file_selector is still active
3 participants