Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple add base url support #1635

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

dinhlongviolin1
Copy link
Member

Related to Avaiga/taipy-designer#143

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.19122686771762%

St.
Category Percentage Covered / Total
🟢 Statements
86.68% (-0.08% 🔻)
3065/3536
🟡 Branches
69.19% (-0.71% 🔻)
2019/2918
🟢 Functions
82.25% (-0.23% 🔻)
556/676
🟢 Lines
87.19% (-0.09% 🔻)
2838/3255
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
100% 91.3% 100% 100%
🟡
... / TaipyRendered.tsx
64.58% 14.29% 50% 64.58%
🟡
... / index.ts
75.51% 26.67% 50% 75%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%

Test suite run success

557 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from 58cf590

@dinhlongviolin1 dinhlongviolin1 changed the title add base url support Decouple add base url support Aug 5, 2024
FabienLelaquais
FabienLelaquais previously approved these changes Aug 5, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to see Designer...

frontend/taipy-gui/base/src/app.ts Show resolved Hide resolved
frontend/taipy-gui/base/src/utils.ts Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Aug 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19102 16127 84% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/custom/_page.py 55% 🟢
taipy/gui/server.py 80% 🟢
taipy/gui/state.py 84% 🟢
TOTAL 73% 🟢

updated for commit: 58cf590 by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dinhlongviolin1 dinhlongviolin1 merged commit 98660d8 into develop Aug 5, 2024
160 checks passed
@dinhlongviolin1 dinhlongviolin1 deleted the feature/decouple-base-url branch August 5, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants