Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add current scope variables when evaluating an expression #2250

Merged
merged 6 commits into from
Nov 14, 2024
Merged

add current scope variables when evaluating an expression #2250

merged 6 commits into from
Nov 14, 2024

Conversation

FredLL-Avaiga
Copy link
Member

resolves #2242

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

When using lambda in another page context, the locals are not resolved

Related Tickets & Documents

How to reproduce the issue

see issue

Checklist

  • Does this solution meet the acceptance criteria of the related issue?
  • Is the related issue checklist completed?
  • Does this PR adds unit tests for the developed code? If not, why?
  • End-to-End tests have been added or updated?
  • Was the documentation updated, or a dedicated issue for documentation created? (If applicable)
  • Is the release notes updated? (If applicable)

@FredLL-Avaiga FredLL-Avaiga self-assigned this Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19291 16776 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/utils/_evaluator.py 85% 🟢
TOTAL 85% 🟢

updated for commit: 12a9f5f by action🐍

FabienLelaquais
FabienLelaquais previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

tests/gui/gui_specific/test_evaluator.py Outdated Show resolved Hide resolved
FabienLelaquais
FabienLelaquais approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FredLL-Avaiga FredLL-Avaiga merged commit c9e0931 into develop Nov 14, 2024
54 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#2242-lambda-scope branch November 14, 2024 16:43
@arcanaxion arcanaxion mentioned this pull request Dec 3, 2024
Closed
7 tasks
@FabienLelaquais FabienLelaquais mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

@dinhlongviolin1 dinhlongviolin1 dinhlongviolin1 approved these changes

@namnguyen20999 namnguyen20999 Awaiting requested review from namnguyen20999

Assignees

@FredLL-Avaiga FredLL-Avaiga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Scope issue with lambda function
3 participants
@FredLL-Avaiga @dinhlongviolin1 @FabienLelaquais