Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure path is in unix format #2267

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

joaoandre-avaiga
Copy link
Collaborator

@joaoandre-avaiga joaoandre-avaiga commented Nov 21, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

When creating a file datanode(csv, excel, json, etc) on a windows host machine the path points to a location on the filesystem with the windows path syntax(C:\Users\foo\file.csv). If the user tries to run a unix base Docker container to execute the same code, an error will ocur because the python interpreter can't understand the path.

Related Tickets & Documents

How to reproduce the issue

The steps to reproduce the issue can be found on the reported issue.

Checklist

We encourage you to keep the code coverage percentage at 80% and above.

  • Does this solution meet the acceptance criteria of the related issue?
  • Is the related issue checklist completed?
  • Does this PR adds unit tests for the developed code? If not, why?
  • End-to-End tests have been added or updated?
  • Was the documentation updated, or a dedicated issue for documentation created? (If applicable)
  • Is the release notes updated? (If applicable)

Copy link
Contributor

github-actions bot commented Nov 21, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19342 16817 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/_entity/_properties.py 100% 🟢
taipy/core/common/_utils.py 100% 🟢
taipy/core/config/data_node_config.py 99% 🟢
taipy/core/data/_file_datanode_mixin.py 98% 🟢
TOTAL 99% 🟢

updated for commit: 5ab4e9a by action🐍

Copy link
Member

@trgiangdo trgiangdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new normalized method looks good to me.

However, it's breaking the tests on file-based data node.

@joaoandre-avaiga joaoandre-avaiga force-pushed the fix/#2221-normalize-path branch 7 times, most recently from cf7bc01 to 299ca76 Compare November 25, 2024 00:21
@joaoandre-avaiga joaoandre-avaiga merged commit 8f0142b into develop Nov 25, 2024
126 checks passed
@joaoandre-avaiga joaoandre-avaiga deleted the fix/#2221-normalize-path branch November 25, 2024 22:21
@joaoandre-avaiga joaoandre-avaiga mentioned this pull request Nov 25, 2024
9 tasks
joaoandre-avaiga added a commit that referenced this pull request Nov 26, 2024
* fix: make sure path is in unix format

* fix: add normalize_path to utils
joaoandre-avaiga added a commit that referenced this pull request Dec 9, 2024
* fix: make sure path is in unix format

* fix: add normalize_path to utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Problem of intercompability between environment Docker/Un*x and Windows for path
3 participants