-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sure path is in unix format #2267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
joaoandre-avaiga
force-pushed
the
fix/#2221-normalize-path
branch
from
November 22, 2024 00:18
2eedc05
to
878c701
Compare
trgiangdo
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new normalized method looks good to me.
However, it's breaking the tests on file-based data node.
joaoandre-avaiga
force-pushed
the
fix/#2221-normalize-path
branch
7 times, most recently
from
November 25, 2024 00:21
cf7bc01
to
299ca76
Compare
joaoandre-avaiga
force-pushed
the
fix/#2221-normalize-path
branch
from
November 25, 2024 00:22
299ca76
to
5ab4e9a
Compare
jrobinAV
approved these changes
Nov 25, 2024
joaoandre-avaiga
added a commit
that referenced
this pull request
Nov 26, 2024
* fix: make sure path is in unix format * fix: add normalize_path to utils
joaoandre-avaiga
added a commit
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When creating a file datanode(csv, excel, json, etc) on a windows host machine the path points to a location on the filesystem with the windows path syntax(
C:\Users\foo\file.csv
). If the user tries to run a unix base Docker container to execute the same code, an error will ocur because the python interpreter can't understand the path.Related Tickets & Documents
How to reproduce the issue
The steps to reproduce the issue can be found on the reported issue.
Checklist
We encourage you to keep the code coverage percentage at 80% and above.