Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flickering on empty table refresh #2277

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

FredLL-Avaiga
Copy link
Member

resolves #2275

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Fix empty table flicker on refresh

Related Tickets & Documents

How to reproduce the issue

import numpy as np

import taipy.gui.builder as tgb
from taipy.gui import Gui

n_rows = 5
base_df = np.random.random((100, 10)).tolist()
df = base_df[:n_rows]

with tgb.Page() as page:
    tgb.toggle(theme=True)
    tgb.text("# Flickering table", mode="md")
    tgb.slider(value="{n_rows}")
    tgb.button("Refresh", on_action=lambda state: state.assign("df", base_df[:state.n_rows]))
    tgb.table("{df}")

    for _ in range(5):
        with tgb.part():
            tgb.text("# Example text", mode="md")

Gui(page).run(title="2275 [🐛 BUG] Table flickers and occupies a lot of space when updating to no rows")

@FredLL-Avaiga FredLL-Avaiga added 💥Malfunction Addresses an identified problem. 🟩 Priority: Low Low priority and doesn't need to be rushed GUI: Front-End labels Nov 25, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Nov 25, 2024
Copy link
Contributor

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 52.07920792079208%

St.
Category Percentage Covered / Total
🔴 Statements 52.08% 263/505
🔴 Branches 21.75% 67/308
🔴 Functions 14.66% 17/116
🔴 Lines 53.42% 242/453

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from c8df938

Copy link
Contributor

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.48801420538621%

St.
Category Percentage Covered / Total
🟢 Statements 87.86% 3446/3922
🟡 Branches
69.49% (+0% 🔼)
2348/3379
🟢 Functions 83.79% 636/759
🟢 Lines 88.32% 3191/3613
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / PaginatedTable.tsx
86%
78.2% (-0.41% 🔻)
77.78% 86.98%

Test suite run success

698 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from c8df938

Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19331 16806 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: c8df938 by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@FredLL-Avaiga FredLL-Avaiga added the 📝Release Notes Impacts the Release Notes or the Documentation in general label Nov 25, 2024
@FredLL-Avaiga FredLL-Avaiga merged commit e97ed37 into develop Nov 25, 2024
133 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#2275-empty-table-refresh-flicker branch November 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 💥Malfunction Addresses an identified problem. 🟩 Priority: Low Low priority and doesn't need to be rushed 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Table flickers and occupies a lot of space when updating to no rows
2 participants