Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css syntax for Metric component #2318

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

namnguyen20999
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Resolve issue when width/height with CSS units not working for metrics

from taipy.gui import Gui

value = 45

page = """
<|{value}|metric|width=30rem|height=30rem|>
"""
image

Related Tickets & Documents

resolve issue #2141

Checklist

We encourage you to keep the code coverage percentage at 80% and above.

  • Does this solution meet the acceptance criteria of the related issue?
  • Is the related issue checklist completed?
  • Does this PR adds unit tests for the developed code? If not, why?
  • End-to-End tests have been added or updated?
  • Was the documentation updated, or a dedicated issue for documentation created? (If applicable)
  • Is the release notes updated? (If applicable)

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 51.87376725838264%

St.
Category Percentage Covered / Total
🔴 Statements 51.87% 263/507
🔴 Branches 21.61% 67/310
🔴 Functions 14.66% 17/116
🔴 Lines 53.19% 242/455

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 511646f

Copy link
Contributor

github-actions bot commented Dec 11, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19486 16952 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 511646f by action🐍

@FabienLelaquais FabienLelaquais linked an issue Dec 11, 2024 that may be closed by this pull request
7 tasks
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@namnguyen20999 namnguyen20999 merged commit bf6c3a4 into develop Dec 12, 2024
133 checks passed
@namnguyen20999 namnguyen20999 deleted the bug/#2141-metric-width-height-css branch December 12, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Setting width/height with CSS units not working for metrics
2 participants