Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2319 #2321

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix issue 2319 #2321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions taipy/core/_orchestrator/_dispatcher/_job_dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,7 @@ def _update_job_status(job: Job, exceptions):
_TaipyLogger._get_logger().error(st)
_JobManagerFactory._build_manager()._set(job)
else:
for output in job.task.output.values():
output.track_edit(job_id=job.id)
output.unlock_edit()
job.completed()
2 changes: 1 addition & 1 deletion taipy/core/_orchestrator/_dispatcher/_task_function_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def _write_data(self, outputs: List[DataNode], results, job_id: JobId):
for res, dn in zip(_results, outputs):
try:
data_node = data_manager._get(dn.id)
data_node.write(res, job_id=job_id)
data_node._write(res)
except Exception as e:
logger.error("Error during write", exc_info=1)
exceptions.append(DataNodeWritingError(f"Error writing in datanode id {dn.id}: {e}"))
Expand Down
6 changes: 3 additions & 3 deletions tests/core/job/test_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ def job(task, job_id):

@pytest.fixture
def replace_in_memory_write_fct():
default_write = InMemoryDataNode.write
InMemoryDataNode.write = _error
default_write = InMemoryDataNode._write
InMemoryDataNode._write = _error
yield
InMemoryDataNode.write = default_write
InMemoryDataNode._write = default_write


def _foo():
Expand Down
Loading