Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow additional buttons in login #2347

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

FredLL-Avaiga
Copy link
Member

resolves #2326

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

login with additional buttons

Related Tickets & Documents

How to reproduce the issue

from taipy.gui import Gui


def on_login(state, id: str, payload: dict):
    print(f"on_login(state, id: {id}, payload: {payload})")

page = """
<|this is a login|login|labels=first button;second button|>
"""

Gui(page).run(title="2326 login - with labels")

image

@FredLL-Avaiga FredLL-Avaiga added 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI 🟧 Priority: High Must be addressed as soon 📝Release Notes Impacts the Release Notes or the Documentation in general labels Dec 17, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Dec 17, 2024
Copy link
Contributor

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 51.87376725838264%

St.
Category Percentage Covered / Total
🔴 Statements 51.87% 263/507
🔴 Branches 21.61% 67/310
🔴 Functions 14.66% 17/116
🔴 Lines 53.19% 242/455

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from e64858f

Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19463 16967 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/_renderers/factory.py 96% 🟢
TOTAL 96% 🟢

updated for commit: e64858f by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks neat and coherent with dialog... nice!

@FredLL-Avaiga FredLL-Avaiga merged commit 72b1e44 into develop Dec 17, 2024
133 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#2326-login-addtional-buttons branch December 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟧 Priority: High Must be addressed as soon 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a custom button in the login visual element
3 participants