Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2152 on submission change called twice with same status (#2353) #2355

Conversation

FredLL-Avaiga
Copy link
Member

What type of PR is this? (check all applicable)

  • Forward port
  • Bug Fix
  • Optimization
  • Documentation Update

Description

#2305 normalize components height
#2152 on submission change called twice with same status (#2353)

Related Tickets & Documents

@FredLL-Avaiga FredLL-Avaiga added Core Related to Taipy Core 🟥 Priority: Critical Must be addressed as soon as possible 🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. labels Dec 18, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 51.87376725838264%

St.
Category Percentage Covered / Total
🔴 Statements 51.87% 263/507
🔴 Branches 21.61% 67/310
🔴 Functions 14.66% 17/116
🔴 Lines 53.19% 242/455

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 1386f9f

Copy link
Contributor

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.11174785100287%

St.
Category Percentage Covered / Total
🟢 Statements
87.44% (-0.05% 🔻)
3501/4004
🟡 Branches 69.11% 2412/3490
🟢 Functions
83.31% (-0.13% 🔻)
649/779
🟢 Lines
87.88% (-0.05% 🔻)
3242/3689
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Input.tsx
90.07% (-1.42% 🔻)
68.15%
90% (-3.33% 🔻)
89.63% (-1.48% 🔻)

Test suite run success

713 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from cd61df1

Copy link
Contributor

github-actions bot commented Dec 18, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19471 16975 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui_core/_context.py 62% 🟢
TOTAL 62% 🟢

updated for commit: 1386f9f by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@FredLL-Avaiga FredLL-Avaiga merged commit cacd400 into develop Dec 20, 2024
135 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the forwardport/#2152-#2305-on-submission-change-and-stylekit branch December 20, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to Taipy Core 🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] On_submission_change - submission is completed twice
3 participants