Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell: add action, pre-commit, config and make it fix some typos #606

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

yarikoptic
Copy link
Contributor

you asked in email to contribute -- here is one ;-)

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w || :",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w -i 3 -C 2",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@jrobinAV
Copy link
Member

Thank you for your contribution.
It looks good to me.
@joaoandre-avaiga Can you have a look at it as well to ensure it fits with the refactoring of the CI/CD you are currently working on?

Thx

@joaoandre-avaiga
Copy link
Collaborator

Thank you for the contribution! For sure, that looks good for me.

@jrobinAV
Copy link
Member

@yarikoptic We are in the middle of a repository merge and a deep refactoring of the Taipy CI/CD.
The tests are failing (in your PR case because of timeout), for external reasons. We are currently working on it.

I propose to merge your PR now even if the test GitHub action is not repaired yet, so we can benefit from your contribution in the new CI/CD.

Thank you.

@jrobinAV jrobinAV merged commit e56732c into Avaiga:develop Dec 19, 2023
14 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants