Updated utils.py for better warning messages #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredLL-Avaiga
requested changes
Dec 19, 2023
FredLL-Avaiga
requested changes
Dec 20, 2023
FredLL-Avaiga
requested changes
Dec 21, 2023
|
how do i resolve these linter errors |
Hello @srinivaspavan9, sorry for the late response. First you need to merge your branch with the latest Avaiga:develop branch. Then, in the linter error log, I saw that which means that the line you edited is too long. Please address the issue before we can merge your change to Taipy. Thank you |
|
Hi @srinivaspavan9, |
FredLL-Avaiga
changed the base branch from
develop
to
feature/#379-better-message
FredLL-Avaiga
merged commit 504caaf
into
Avaiga:feature/#379-better-message
16 of 18 checks passed
FredLL-Avaiga
added a commit
that referenced
this pull request
Mar 13, 2024
* Updated utils.py for better warning messages (#617) * Updated utils.py for better warning messages * added value check for dataframe * added the check at the warning level * resolved linter comments * added required changes * Linter Changes * Linter Changes --------- Co-authored-by: Fred Lefévère-Laoide <[email protected]> * format and small fix * Update taipy/gui/_renderers/utils.py Co-authored-by: Fabien Lelaquais <[email protected]> * Update taipy/gui/_renderers/utils.py Co-authored-by: Fabien Lelaquais <[email protected]> * mypy * linter --------- Co-authored-by: Srinivas Pavan <[email protected]> Co-authored-by: Fred Lefévère-Laoide <[email protected]> Co-authored-by: Fabien Lelaquais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Warning Message in utils.py for Issue #379
This PR addresses BUG-Inputting the wrong column name in a chart reports empty data (#379). The issue was due to the misleading warning message in
utils.py, which implied an empty DataFrame when a non-existent column name was used.Changes Made:
Screenshot after the change: