Rename and update sequence #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y exists before setting the sequence
I would need the context manager to update the tasks list |
FabienLelaquais
previously approved these changes
Feb 12, 2024
| @@ -74,7 +74,8 @@ def __init__( | |||
|
|
|||
| @staticmethod | |||
| def _new_id(sequence_name: str, scenario_id) -> SequenceId: | |||
| return SequenceId(Sequence._SEPARATOR.join([Sequence._ID_PREFIX, _validate_id(sequence_name), scenario_id])) | |||
| seq_id = sequence_name.replace(" ", "_") | |||
There was a problem hiding this comment.
Sure about that? Only spaces are a problem?
FredLL-Avaiga
previously approved these changes
Feb 12, 2024
jrobinAV
dismissed stale reviews from FredLL-Avaiga and FabienLelaquais
via
b40341f
jrobinAV
commented
Feb 12, 2024
| assert scenario.sequences["seq_1"].properties["new_key"] == "new_value" | ||
|
|
||
|
|
||
| def test_add_rename_and_remove_sequences_within_context(data_node): |
There was a problem hiding this comment.
@FredLL-Avaiga This test exhibits the fix
FredLL-Avaiga
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #812
add_sequencemethod to check if a sequence already exists with the same name.NonExistingSequenceexception message.