Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table csv download #944

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

FredLL-Avaiga
Copy link
Member

add a downloadable boolean property to table

resolves #427

@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible ✨New feature 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End Gui: Back-End labels Mar 7, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 62.34413965087282%

St.
Category Percentage Covered / Total
🟢 Statements
80.6% (-0.02% 🔻)
2401/2979
🟡 Branches
62.34% (-0.01% 🔻)
1500/2406
🟡 Functions
73.84% (-0.27% 🔻)
412/558
🟢 Lines
81.07% (-0.02% 🔻)
2236/2758
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / PaginatedTable.tsx
77.01% (-0.17% 🔻)
70.73% (+0.41% 🔼)
71.05% (-1.92% 🔻)
77.65% (-0.19% 🔻)
🟡
... / AutoLoadingTable.tsx
73.33% (-0.11% 🔻)
50.63% (-0.37% 🔻)
61.36% (-1.43% 🔻)
74.4% (-0.14% 🔻)

Test suite run success

355 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from caab1ad

Copy link
Contributor

github-actions bot commented Mar 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
17786 15693 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/_renderers/factory.py 96% 🟢
taipy/gui/data/pandas_data_accessor.py 72% 🟢
taipy/gui/gui.py 82% 🟢
TOTAL 83% 🟢

updated for commit: caab1ad by action🐍

Fred Lefévère-Laoide added 2 commits March 7, 2024 15:54
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taipy/gui/gui.py Show resolved Hide resolved
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@FredLL-Avaiga FredLL-Avaiga merged commit bdbaf83 into develop Mar 7, 2024
149 of 154 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#427-table-csv-download branch March 7, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gui: Back-End GUI: Front-End ✨New feature 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to download a Taipy table as a CSV file
3 participants