Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_selector notify property (default True) #946

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

FredLL-Avaiga
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga commented Mar 8, 2024

basic support for TimeDelta (could be enhanced via specific jsonAdapter)
resolves #573
resolves #455


import pandas as pd

from taipy.gui import Gui

data = {"label": ["red", "white"], "timedelta": [pd.Timedelta(days=1), pd.Timedelta(days=2)]}

md = """
<|{data}|table|>
<|file_selector|don't notify|>
"""

Gui(md).run()

support TimleDelta
resolves #573
resolves #455
@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 📈 Improvement Improvement of a feature. 💥Malfunction Addresses an identified problem. 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End Gui: Back-End labels Mar 8, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Mar 8, 2024
FabienLelaquais
FabienLelaquais previously approved these changes Mar 8, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 62.2563251762754%

St.
Category Percentage Covered / Total
🟢 Statements
80.6% (+0.06% 🔼)
2401/2979
🟡 Branches
62.26% (-0.64% 🔻)
1501/2411
🟡 Functions
73.84% (-0.21% 🔻)
412/558
🟢 Lines
81.07% (+0.07% 🔼)
2236/2758
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
66.67% 17.65% 50% 66.67%
🟡
... / index.ts
73.91% 26.67% 50% 73.33%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
62.5% 0% 0% 60%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / FileSelector.tsx
64.29%
45% (-3.57% 🔻)
30.77% 63.77%

Test suite run success

355 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from e74c8b3

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

github-actions bot commented Mar 8, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
17794 15698 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/_renderers/factory.py 96% 🟢
taipy/gui/_renderers/json.py 79% 🟢
TOTAL 88% 🟢

updated for commit: e74c8b3 by action🐍

@FredLL-Avaiga FredLL-Avaiga merged commit 1903c9b into develop Mar 8, 2024
65 of 66 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#573-file_selector-no-notify branch March 8, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gui: Back-End GUI: Front-End 📈 Improvement Improvement of a feature. 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not notify "Upload succesful" when uploading a file using file_selector Timedelta in tables
2 participants