Test/integration testing #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5f3996.
jrobinAV
added
Core
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
jrobinAV
commented
Mar 20, 2024
taipy/core/_orchestrator/_dispatcher/_standalone_job_dispatcher.py
Outdated
Show resolved
Hide resolved
| @@ -34,7 +34,7 @@ def _get_logger(cls): | |||
| cls.__logger.setLevel(logging.INFO) | |||
| ch = logging.StreamHandler(sys.stdout) | |||
| ch.setLevel(logging.INFO) | |||
| formatter = logging.Formatter("[%(asctime)s][%(name)s][%(levelname)s] %(message)s", "%Y-%m-%d %H:%M:%S") | |||
| ch.setFormatter(formatter) | |||
| f = logging.Formatter("[%(asctime)s.%(msecs)03d][%(name)s][%(levelname)s] %(message)s", "%Y-%m-%d %H:%M:%S") | |||
There was a problem hiding this comment.
Add milliseconds to default logging format.
There was a problem hiding this comment.
Will this cause too much noise?
It affects the whole application so I think we need third opinion about this
There was a problem hiding this comment.
My opinion is that in a multithreading/multiprocessing context, having milliseconds in the logs is more than useful to understand what's happening. This is not only true for us as developers but also for our users.
However, I agree we should discuss it during the daily to have more opinions on that.
There was a problem hiding this comment.
@FlorianJacta @FabienLelaquais Is it ok for you to have a default log formatting with milliseconds?
taipy/core/_orchestrator/_dispatcher/_standalone_job_dispatcher.py
Outdated
Show resolved
Hide resolved
jrobinAV
removed
the
❌ Blocked
toan-quach
previously approved these changes
Mar 21, 2024
taipy/core/_orchestrator/_dispatcher/_standalone_job_dispatcher.py
Outdated
Show resolved
Hide resolved
trgiangdo
reviewed
Mar 21, 2024
tests/core/_orchestrator/_dispatcher/mock_standalone_dispatcher.py
Outdated
Show resolved
Hide resolved
toan-quach
previously approved these changes
Mar 21, 2024
trgiangdo
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.