-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve [Bug]/#24 #26
Conversation
Thought that signed... going to do an interactive rebase to have that sign |
done! should be good to go @Awakened-Redstone |
Seems good, I just need to check it a bit more later as the mod runs periodic checks, so may need to add that line to some other parts of the code, like CoreEvents:80 and DiscordDataProcessor:59 I'm sorry for the confusing branches, I'm working on some changes to the repo as AutoWhitelist Lite has been deprecated |
I forgot to mention, the major branch currently is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The roles list is immutable, it has to either be copied to a mutable list or use another method to verify for the @everyone
role.
The user can use a bot to give all users a role, but supporting @everyone
is a nice QoL, also needs to add the extra code to other places that may change the user whitelist, as mentioned on the last comment
my bad, it's been years since I touched java... damn |
chore: Remove unneeded labels and version type
chore: Remove version type
chore: Remove version type
chore: Remove version type
This should be better, was fighting Gradle to use my jdk-17 path (little gremlin)
Please take a look! |
Resolves #24
@Awakened-Redstone @kaydenvg
When executing the whitelist register command in Discord, we take the member's guild's
getPublicRole()
(which isn't returned in the list fromgetRoles()
because it is documented as implicit):and add it explicitly to the roles we're checking on the member.
This allows users to configure the mod using their guild's
@everyone
role, and have it behave as expected.