Feature/compilo vm #102
DwozyTests.yml
on: pull_request
check_compilation
1m 50s
check_style
11s
run_tests
3m 39s
Annotations
6 errors and 15 warnings
|
check_style
HLint failed with status: 1. Warning (6), Suggestion (23)
|
|
run_tests:
LobsterLang/test/VmSpec.hs#L22
Data constructor not in scope: Subtract :: Operator
|
|
run_tests:
LobsterLang/test/VmSpec.hs#L24
Data constructor not in scope: Multiply :: Operator
|
|
run_tests:
LobsterLang/test/VmSpec.hs#L26
Data constructor not in scope: Divide :: Operator
|
|
run_tests:
LobsterLang/test/VmSpec.hs#L28
Data constructor not in scope: Divide :: Operator
|
|
run_tests
Process completed with exit code 2.
|
|
check_style:
LobsterLang/src/CompiletoVm.hs#L49
Suggestion in convert in module CompiletoVm: Use record patterns ▫︎ Found: "Compiler.Def _ _ _" ▫︎ Perhaps: "Compiler.Def {}"
|
|
check_style:
LobsterLang/src/CompiletoVm.hs#L87
Suggestion in convert in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]"
|
|
check_style:
LobsterLang/src/CompiletoVm.hs#L87
Suggestion in convert in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]" ▫︎ Perhaps: "[Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
|
|
check_style:
LobsterLang/src/CompiletoVm.hs#L103
Suggestion in getDefinedValue in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int)))]" ▫︎ Perhaps: "[Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int))]"
|
|
check_style:
LobsterLang/src/CompiletoVm.hs#L117
Suggestion in getDefinedValue in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
|
|
check_style:
LobsterLang/src/CompiletoVm.hs#L144
Suggestion in getList in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int)))]" ▫︎ Perhaps: "[Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int))]"
|
|
check_style:
LobsterLang/src/CompiletoVm.hs#L158
Suggestion in getList in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
|
|
check_style:
LobsterLang/src/Parse.hs#L51
Suggestion in Parser in module Parse: Use newtype instead of data ▫︎ Found: "data Parser a\n = Parser {runParser :: Position\n -> String -> Either String (a, String, Position)}" ▫︎ Perhaps: "newtype Parser a\n = Parser {runParser :: Position\n -> String -> Either String (a, String, Position)}" ▫︎ Note: decreases laziness
|
|
check_style:
LobsterLang/src/Parse.hs#L201
Suggestion in parseString in module Parse: Use <$ ▫︎ Found: "return (value ++ res') <* parseWhiteSpace" ▫︎ Perhaps: "(value ++ res') Data.Functor.<$ parseWhiteSpace"
|
|
check_style:
LobsterLang/src/Vm.hs#L42
Warning in module Vm: Redundant bracket ▫︎ Found: "(0)" ▫︎ Perhaps: "0"
|
|
run_tests:
LobsterLang/test/AstEvalSpec.hs#L1
The export item ‘module AstEvalSpec’ is missing an export list
|
|
run_tests:
LobsterLang/test/AstOptimizerSpec.hs#L1
The export item ‘module AstOptimizerSpec’ is missing an export list
|
|
run_tests:
LobsterLang/test/CompilerSpec.hs#L1
The export item ‘module CompilerSpec’ is missing an export list
|
|
run_tests:
LobsterLang/test/CompilerSpec.hs#L11
The import of ‘Data.Maybe’ is redundant
|
|
run_tests:
LobsterLang/test/ParserSpec.hs#L1
The export item ‘module ParserSpec’ is missing an export list
|