Feature/compilo vm #104
Annotations
1 error and 10 warnings
|
Run HLint
HLint failed with status: 1. Warning (6), Suggestion (23)
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L49
Suggestion in convert in module CompiletoVm: Use record patterns ▫︎ Found: "Compiler.Def _ _ _" ▫︎ Perhaps: "Compiler.Def {}"
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L87
Suggestion in convert in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]"
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L87
Suggestion in convert in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]" ▫︎ Perhaps: "[Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L103
Suggestion in getDefinedValue in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int)))]" ▫︎ Perhaps: "[Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int))]"
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L117
Suggestion in getDefinedValue in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L144
Suggestion in getList in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int)))]" ▫︎ Perhaps: "[Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int))]"
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L158
Suggestion in getList in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
|
|
Run HLint:
LobsterLang/src/Parse.hs#L51
Suggestion in Parser in module Parse: Use newtype instead of data ▫︎ Found: "data Parser a\n = Parser {runParser :: Position\n -> String -> Either String (a, String, Position)}" ▫︎ Perhaps: "newtype Parser a\n = Parser {runParser :: Position\n -> String -> Either String (a, String, Position)}" ▫︎ Note: decreases laziness
|
|
Run HLint:
LobsterLang/src/Parse.hs#L201
Suggestion in parseString in module Parse: Use <$ ▫︎ Found: "return (value ++ res') <* parseWhiteSpace" ▫︎ Perhaps: "(value ++ res') Data.Functor.<$ parseWhiteSpace"
|
|
Run HLint:
LobsterLang/src/Vm.hs#L42
Warning in module Vm: Redundant bracket ▫︎ Found: "(0)" ▫︎ Perhaps: "0"
|
The logs for this run have expired and are no longer available.
Loading