Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean code #60

Merged
merged 16 commits into from
Feb 18, 2024
Merged

Clean code #60

merged 16 commits into from
Feb 18, 2024

Conversation

AxelHumeau
Copy link
Owner

No description provided.

@AxelHumeau
test: fix tests
09e9590
@AxelHumeau
style: clean coding style errors from Main.hs and AstEval.hs
958a8ec
@AxelHumeau
style: remove too long lines in AstOptimizer.hs
e50a283
@AxelHumeau
style: removed majority of coding style errors in AstOptimizer.hs
9815508
@AxelHumeau
style: remove coding style error in Compiler.hs
f8c9811
@AxelHumeau
style: fix too long function for convert function CompilerToVm.hs
d49d81d
@AxelHumeau
style: fix some too long lines in CompilerToVm.hs
04b8ae3
@AxelHumeau
style: fix some too long functions in CompilerToVm.hs
0053173
@AxelHumeau
refactor: add type alias for either decoded result
00b45b8
@AxelHumeau
style: fix coding style error in getInstructionFunc
37eaca2
@AxelHumeau
style: fix coding style error in getList
0dec7b2
@AxelHumeau
chore: removed binary files
f31bc0b
@AxelHumeau
style: finished cleaning CompilerToVm.hs
1a4aae7
@AxelHumeau
style: remove almost all errors remaining
72be232
@AxelHumeau
style: only one left
7ef9370
@AxelHumeau
style: clean all style errors remaining
af7fd1f
@AxelHumeau AxelHumeau requested review from AldricJourdain and Dwozy and removed request for AldricJourdain February 18, 2024 16:47
AldricJourdain
AldricJourdain approved these changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@AldricJourdain AldricJourdain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@AxelHumeau AxelHumeau merged commit 1d77b56 into main Feb 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AldricJourdain AldricJourdain AldricJourdain approved these changes

@Dwozy Dwozy Awaiting requested review from Dwozy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AxelHumeau @AldricJourdain