Temporarily disable signing until we can figure out a new way

AxioDL · Dec 15, 2023 · 200a2f0 · 200a2f0
1 parent 82e4fdc
commit 200a2f0
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 30 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -148,19 +148,20 @@ jobs:
         if: 'false' # temporarily disabled
         run: buildcache -s
 
-      - name: Import signing certificate
-        uses: devbotsxyz/xcode-import-certificate@master
-        with:
-          certificate-data: ${{secrets.MACOS_CERTIFICATE_DATA}}
-          certificate-passphrase: ${{secrets.MACOS_CERTIFICATE_PASSWORD}}
-          keychain-password: ${{secrets.MACOS_KEYCHAIN_PASSWORD}}
+      #- name: Import signing certificate
+       # if: 'false' # temporarily disabled
+        #uses: devbotsxyz/xcode-import-certificate@master
+        #with:
+        #  certificate-data: ${{secrets.MACOS_CERTIFICATE_DATA}}
+        #  certificate-passphrase: ${{secrets.MACOS_CERTIFICATE_PASSWORD}}
+        #  keychain-password: ${{secrets.MACOS_KEYCHAIN_PASSWORD}}
 
       - name: Deploy & codesign application
-        env:
-          ASC_USERNAME: ${{secrets.MACOS_ASC_USERNAME}}
-          ASC_PASSWORD: ${{secrets.MACOS_ASC_PASSWORD}}
-          ASC_TEAM_ID: ${{secrets.MACOS_ASC_TEAM_ID}}
-          CODESIGN_IDENT: ${{secrets.MACOS_CODESIGN_IDENT}}
+        #env:
+          #ASC_USERNAME: ${{secrets.MACOS_ASC_USERNAME}}
+          #ASC_PASSWORD: ${{secrets.MACOS_ASC_PASSWORD}}
+          #ASC_TEAM_ID: ${{secrets.MACOS_ASC_TEAM_ID}}
+          #CODESIGN_IDENT: ${{secrets.MACOS_CODESIGN_IDENT}}
         run: ci/build-dmg.sh
 
       - name: Upload artifacts

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -168,19 +168,19 @@ jobs:
           SENTRY_URL: ${{secrets.SENTRY_URL}}
         run: ci/upload-debug-macos.sh
 
-      - name: Import signing certificate
-        uses: devbotsxyz/xcode-import-certificate@master
-        with:
-          certificate-data: ${{ secrets.MACOS_CERTIFICATE_DATA }}
-          certificate-passphrase: ${{ secrets.MACOS_CERTIFICATE_PASSWORD }}
-          keychain-password: ${{ secrets.MACOS_KEYCHAIN_PASSWORD }}
+      #- name: Import signing certificate
+      #  uses: devbotsxyz/xcode-import-certificate@master
+      #  with:
+      #    certificate-data: ${{ secrets.MACOS_CERTIFICATE_DATA }}
+      #    certificate-passphrase: ${{ secrets.MACOS_CERTIFICATE_PASSWORD }}
+      #    keychain-password: ${{ secrets.MACOS_KEYCHAIN_PASSWORD }}
 
       - name: Deploy & codesign application
-        env:
-          ASC_USERNAME: ${{secrets.MACOS_ASC_USERNAME}}
-          ASC_PASSWORD: ${{secrets.MACOS_ASC_PASSWORD}}
-          ASC_TEAM_ID: ${{secrets.MACOS_ASC_TEAM_ID}}
-          CODESIGN_IDENT: ${{secrets.MACOS_CODESIGN_IDENT}}
+        #env:
+        #  ASC_USERNAME: ${{secrets.MACOS_ASC_USERNAME}}
+        #  ASC_PASSWORD: ${{secrets.MACOS_ASC_PASSWORD}}
+        #  ASC_TEAM_ID: ${{secrets.MACOS_ASC_TEAM_ID}}
+        # CODESIGN_IDENT: ${{secrets.MACOS_CODESIGN_IDENT}}
         run: ci/build-dmg.sh
 
       - name: Upload artifacts

diff --git a/ci/build-dmg.sh b/ci/build-dmg.sh
@@ -1,10 +1,10 @@
 #!/bin/bash -ex
 cd build/install
-for i in Metaforce crashpad_handler; do
-  if [ -x "Metaforce.app/Contents/MacOS/$i" ]; then
-    codesign --timestamp --options runtime -s "$CODESIGN_IDENT" "Metaforce.app/Contents/MacOS/$i"
-  fi
-done
-create-dmg Metaforce.app --identity="$CODESIGN_IDENT" .
-xcrun altool -t osx -f *.dmg --primary-bundle-id com.axiodl.Metaforce \
-  --notarize-app -u "$ASC_USERNAME" -p "$ASC_PASSWORD" --team-id "$ASC_TEAM_ID"
+#for i in Metaforce crashpad_handler; do
+#  if [ -x "Metaforce.app/Contents/MacOS/$i" ]; then
+#    codesign --timestamp --options runtime -s "$CODESIGN_IDENT" "Metaforce.app/Contents/MacOS/$i"
+#  fi
+#done
+create-dmg Metaforce.app . #--identity="$CODESIGN_IDENT" .
+#xcrun altool -t osx -f *.dmg --primary-bundle-id com.axiodl.Metaforce \
+#  --notarize-app -u "$ASC_USERNAME" -p "$ASC_PASSWORD" --team-id "$ASC_TEAM_ID"