drop SORT_BY for single checks, add VALID_TOKENS, revert find_best_results_from_backtesting_log() #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azulinho
force-pushed
the
next_release
branch
3 times, most recently
from
68b4b8f to
3be3d5b
Compare
Azulinho
changed the title
Azulinho
force-pushed
the
next_release
branch
2 times, most recently
from
31fbb93 to
cbfdd5e
Compare
This introduces MINS_WINS, MIN_PROFIT, MAX_LOSSES, MAX_STALES, MAX_HOLDS
alongside FILTER_BY this new VALID_TOKENS prove-backtesting config takes a list of strings which is used by the prove-backtesting runner to exclude any tokens not in the list. example: VALID_TOKENS: ["BTC", "ETH"] when set to [] all tokens are valid
re-arranges the order of ADD commands in the dockerfile to improve repeated builds times. such as when testing locally
Azulinho
force-pushed
the
next_release
branch
from
cbfdd5e to
bc8e042
Compare
Azulinho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts find_best_results_from_backtesting_log() broken since 0.0.200
prove-backtesting was setting the first run with valid results it would find and not updating it with better results.
adds .envrc with support for .envrc.local
fixes removal of stale lockfiles on unclean shutdowns
adds VALID_TOKENS
replaces SORT_BY with: MIN_WINS, MIN_PROFIT, MAX_LOSSES, MAX_STALES, MAX_HOLDS
best results are now always chosen on profit according to the settings above.
additional cleanup of temp files