Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove un-required version number and tidy docs #685

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Nov 16, 2023

Overview/Summary

This PR removes a version number that is no longer required. The ALZ PowerShell module now handles the version. The config setting need to be retained in the config.json for the time being.

This PR fixes/adds/changes/removes

  1. env file is generating wrong UPSTREAM_RELEASE_VERSION #684 (The actual fix is in bug: upstream release version env var ALZ-PowerShell-Module#88), but this is part of the same thing

Breaking Changes

  1. None

Testing Evidence

Generated env file now contains the correct version even when pulling the wrong config.

image

As part of this Pull Request I have

@jaredfholgate jaredfholgate requested a review from a team as a code owner November 16, 2023 12:33
@jtracey93 jtracey93 merged commit ef8a90c into main Nov 16, 2023
7 checks passed
@jtracey93 jtracey93 deleted the chore-tidy-version-number branch November 16, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants