Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tfvars for inputs and lib for vnext #251

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Nov 18, 2024

Pull Request

Description

There are three key features implemented here:

  • Support tfvars as an input format.
  • Support tfvars pass through for Terraform starter modules in order to provide a good experience for customers with day 2 operations.
  • Support supplying a lib folder (or any arbitrary files or folders) to support vNext customisation.

End to end tests will be run to confirm there are no breaking changes.

e2e test run is here: https://github.com/Azure/accelerator-bootstrap-modules/actions/runs/11955283956

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@github-actions github-actions bot added the Needs: Triage 🔍 Needs triaging by the team label Nov 18, 2024
@jaredfholgate jaredfholgate changed the title Save changes feat: support tfvars for inputs and direct starter copy Nov 18, 2024
@jaredfholgate jaredfholgate self-assigned this Nov 18, 2024
@jaredfholgate jaredfholgate changed the title feat: support tfvars for inputs and direct starter copy feat: support tfvars for inputs and lib for vnext Nov 21, 2024
@jaredfholgate jaredfholgate marked this pull request as ready for review November 21, 2024 14:28
@jaredfholgate jaredfholgate added Needs: Attention 👋 Needs attention from the maintainers and removed Needs: Triage 🔍 Needs triaging by the team labels Nov 21, 2024
matt-FFFFFF
matt-FFFFFF previously approved these changes Nov 21, 2024
@jaredfholgate jaredfholgate merged commit b560259 into main Nov 22, 2024
4 checks passed
@jaredfholgate jaredfholgate deleted the feat-support-tfvars branch November 22, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention 👋 Needs attention from the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants