.github: do a functional check for az login #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
requested review from
bennerv,
jharrington22,
SudoBrendan,
UlrichSchlueter and
zgalor
as code owners
stevekuznetsov
force-pushed
the
skuznets/redo-fork-check
branch
from
d38939f
to
ea04ae1
Compare
bennerv
reviewed
Nov 23, 2024
|
@bennerv updated! |
stevekuznetsov
force-pushed
the
skuznets/redo-fork-check
branch
from
ea04ae1
to
ce1b5e2
Compare
Instead of checking for the "cause" of login failure, check for the symptom, so we don't get false positives. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/redo-fork-check
branch
from
ce1b5e2
to
41caf63
Compare
bennerv
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking for the "cause" of login failure, check for the symptom, so we don't get false positives.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer