Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Complete Starter Module #10

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Add Complete Starter Module #10

merged 3 commits into from
Sep 22, 2023

Conversation

luke-taylor
Copy link
Contributor

@luke-taylor luke-taylor commented Sep 22, 2023 •
edited by jaredfholgate
Loading

Overview/Summary

  • Added a complete option that unlocks all configurability to the module and ties the modules together.

This PR fixes/adds/changes/removes

Breaking Changes

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-requested a review September 22, 2023 14:32
jaredfholgate
jaredfholgate previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaredfholgate
jaredfholgate approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@luke-taylor luke-taylor merged commit b29d191 into main Sep 22, 2023
3 checks passed
@luke-taylor luke-taylor deleted the dev/full-config branch September 22, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredfholgate jaredfholgate jaredfholgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luke-taylor @jaredfholgate