Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vnet gateway firewall race condition #173

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix: vnet gateway firewall race condition #173

merged 2 commits into from
Oct 3, 2024

Conversation

jaredfholgate
Copy link
Member

Overview/Summary

Resolve a reported race condition when vnet gateway and firewall deploy at the same time.

This PR fixes/adds/changes/removes

N/A

Breaking Changes

None

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this Oct 3, 2024
Springstone
Springstone previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Springstone
Springstone approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate jaredfholgate merged commit 5f35ef7 into main Oct 3, 2024
4 checks passed
@jaredfholgate jaredfholgate deleted the fix-vent-gateway-firewall-race-condition branch October 3, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Springstone Springstone Springstone approved these changes

Assignees

@jaredfholgate jaredfholgate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredfholgate @Springstone