Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Add regex fix for the azure_name to match example #5

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Sep 19, 2023

Overview/Summary

Fix regex issue with azure_name config value not allowing the example (my-azure-name) specified during input.

This PR fixes/adds/changes/removes

  1. Fixes regex to allow additional characters after optional hypen to match my-azure-name example/

Breaking Changes

  1. None

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate
Copy link
Member

jaredfholgate commented Sep 20, 2023

Thanks @oZakari! My regex skills are entirely Google based! :)

@jaredfholgate jaredfholgate merged commit 9e2470f into Azure:main Sep 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants