Add bin/www express script and updated env variable #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating .gitignore to include the /bin folder
Updated the HTTP 2.0 gRPC port environment variable to match the documentation that points out to HTTP20_ONLY_PORT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the missing
bin/wwwexpress script that is present on thepackage.jsonstartscript.If this is used as a sample, running
npm startafternpm installwill fail without thebin/wwwscript.Updated .gitignore to include the
/binfolderIt's not possible to re-include a file if a parent directory of that file is excluded (source) so I opted to remove the
bin/folder from the.gitignorefile.Future
/binoutputs can be specifically excluded. None are present at the moment.Updated the environment variable referencing the HTTP 2.0 Port from
portHttp2toHTTP20_ONLY_PORT, matching the documentation/README.