{Packaging} Remove Jinja2, MarkupSafe and pycparser from requirements.txt #29422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Packaging |
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
|
I searched the whole repo and neither Maybe we can remove them? They were initially added by #9785. |
|
Yes. In this PR I wrote that jinja2 and markupsafe can be removed and I totally forget it. #27717
|
bebound
changed the title
bebound
changed the title
bebound
commented
Jul 19, 2024
| @@ -29,6 +29,7 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| @unittest.skip('alias extension is not working: https://github.com/Azure/azure-cli/issues/29422') | |||
There was a problem hiding this comment.
After removing markupsafe, the alias extension does not work anymore. Previously, the CLI's markupsafe was loaded; now it loads the outdated alias's markupsafe package.
Unable to load extension 'alias: cannot import name 'soft_unicode' from 'markupsafe' (C:\Users\kk\.azure\cliextensions\alias\markupsafe\__init__.py)'. Use --debug for more information.
az feedback drop is tracked in #29426
jiasli
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja2andMarkupSafeare not used in CLI.pycparseris a dependency ofcffi.We don't need to include them in requirements.txt
Resolve #29421