[Client encryption]: Fixes missing files errors at time of nuget publishing. #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aavasthy
requested review from
kirankumarkolli,
FabianMeiswinkel,
sboshra and
Pilchie
as code owners
Pilchie
requested changes
Nov 18, 2024
Pilchie
reviewed
Nov 18, 2024
Microsoft.Azure.Cosmos.Encryption/src/Microsoft.Azure.Cosmos.Encryption.csproj
Outdated
Show resolved
Hide resolved
Pilchie
approved these changes
Nov 18, 2024
NaluTripician
approved these changes
Nov 19, 2024
ananth7592
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
nit: Does the icon.png at line number 30 also needs to be changed to this new path https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/Microsoft.Azure.Cosmos.csproj#L30 ?
PackagePath="" places the Icon.png file at the root of the package so that is why the value does not need to change in this case. |
microsoft-github-policy-service
bot
deleted the
users/aavasthy/fix_encryptionproject_build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Updated the Microsoft.Azure.Cosmos.Encryption package and Microsoft.Azure.Cosmos.Encryption.Custom package so as to fix missing icon.png and license.txt errors when publishing these packages locally.
Type of change
Below the are the errors the project throws while publishing the nuget package.
After the fix is implemented the nuget package publishes successfully.
Closing issues
To automatically close an issue: closes #IssueNumber