Ensuring exception message is used if ModelError.Message is not set

Azure · Jul 9, 2024 · d6dfbae · d6dfbae
1 parent 005f9dc
commit d6dfbae
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/extensions/Worker.Extensions.Http.AspNetCore/release_notes.md b/extensions/Worker.Extensions.Http.AspNetCore/release_notes.md
@@ -6,4 +6,4 @@
 
 ### Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore <version>
 
-- <entry>
+- Fixed a bug that would lead to an empty exception message in some model binding failures.
diff --git a/extensions/Worker.Extensions.Http.AspNetCore/src/FromBodyConversionFeature.cs b/extensions/Worker.Extensions.Http.AspNetCore/src/FromBodyConversionFeature.cs
@@ -84,7 +84,16 @@ internal sealed class FromBodyConversionFeature : IFromBodyConversionFeature
 
                     foreach (var error in dictionary.Errors)
                     {
-                        messageBuilder.AppendLine(error.ErrorMessage);
+                        if (error is null)
+                        {
+                           continue;
+                        }
+
+                        var message = string.IsNullOrEmpty(error.ErrorMessage)
+                            ? error.Exception?.Message
+                            : error.ErrorMessage;
+
+                        messageBuilder.AppendLine(message);
                     }
                 }