Updating and adding guidance for brownfield deployments #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updating artifacts to allow for brownfield deployment - Updating artifacts to allow for brownfield deployment
- Updating guidance - Removing unnecessary artifacts
paulgrimley
reviewed
Sep 22, 2023
There was a problem hiding this comment.
I've reviewed a couple of files for grammar, the rest will need @arjenhuitema to comment
| - Policy Set Definitions | ||
| - Policy Assignment remediation identity role assignments | ||
|
|
||
| All resources deployed as part of the initial ALZ Monitor deployment and the resources created by dynamically by 'deploy if not exist' policies are either tagged, marked in metadata, or in description (depending on what the resource supports) with the value `_deployed_by_alz_monitor` or `_deployed_by_alz_monitor=True`. This metadata is used to execute the cleanup of deployed resources; _if it has been removed or modified the cleanup script will not include those resources_. |
There was a problem hiding this comment.
grammar "by dynamically by"
|
|
||
| All resources deployed as part of the initial ALZ Monitor deployment and the resources created by dynamically by 'deploy if not exist' policies are either tagged, marked in metadata, or in description (depending on what the resource supports) with the value `_deployed_by_alz_monitor` or `_deployed_by_alz_monitor=True`. This metadata is used to execute the cleanup of deployed resources; _if it has been removed or modified the cleanup script will not include those resources_. | ||
|
|
||
| ## Cleanup Script Execution |
There was a problem hiding this comment.
Please add a comment that the script should be thoroughly tested before uisng in production environments and we assume no responsibility in the event of resource or data loss (I think Jan has something he has written previously) and there is one for ALZ clean-up that has something in the comments.
arjenhuitema
pushed a commit
that referenced
this pull request
Mar 20, 2024
Updating noEmail with latest from Main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
As part of this Pull Request I have
mainbranch