Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCore - AVD Initial w/ URL Fixes #114

Merged
merged 3 commits into from
Feb 5, 2024
Merged

JCore - AVD Initial w/ URL Fixes #114

merged 3 commits into from
Feb 5, 2024

Conversation

JCoreMS
Copy link
Contributor

@JCoreMS JCoreMS commented Feb 5, 2024

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Fix non-working deployment buttons (URLs contained "blob" and fix US Gov button for .us vs .com)
  2. Updated URL for Excel file which was also not working from relative path to raw github path so it will open in Office Web App or download.

Breaking Changes

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@JoeyBarnes JoeyBarnes merged commit cc4f181 into Azure:main Feb 5, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants