Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBA - Allow for alert notification suppression during resources maintenance #143

Merged
merged 22 commits into from
Mar 15, 2024

Conversation

Brunoga-MS
Copy link
Contributor

Overview/Summary

This PR will add a suppression APR, deployed as part of the notification Assets policy, in a disabled state which will run always on specific resources. The resourceId of the resources must be entered by the customer based on the need.

This PR fixes/adds/changes/removes

  1. A new APR of type suppression as per customer evidence captured in the AMBA - Allow for alert notification suppression during resources maintenance User Story and [Question/Feedback]: Exclude some resources from being monitored #127
  2. Documentation reference on how to configure the APR when needed
  3. Some documentation improvements
  4. an optimization to the cleanup script

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [] Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS Brunoga-MS requested a review from arjenhuitema March 6, 2024 13:22
@Brunoga-MS Brunoga-MS linked an issue Mar 6, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit e910399 into Azure:main Mar 15, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question/Feedback]: Exclude some resources from being monitored
2 participants