Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deployment name and dependsOn #19

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Update deployment name and dependsOn #19

merged 1 commit into from
Sep 29, 2023

Conversation

arjenhuitema
Copy link
Contributor

@arjenhuitema arjenhuitema commented Sep 29, 2023 •
edited
Loading

Overview/Summary

Fixes some transient deployment issues when deployed with the ALZ Accelerator.

This PR fixes/adds/changes/removes

  1. Changed the deployment name for the loop deployment from "preparingToLaunch" to "ambaPreparingToLaunch"
  2. Changed the name and depends on from "policyCompletion" to "ambaPolicyCompletion"

Breaking Changes

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

jfaurskov
jfaurskov approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit b91bcc6 into Azure:main Sep 29, 2023
1 of 3 checks passed
@arjenhuitema arjenhuitema deleted the portal-update branch September 29, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaurskov jfaurskov jfaurskov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arjenhuitema @jfaurskov