Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bryanzab/update references #20

Merged
merged 5 commits into from
Sep 30, 2023
Merged

Conversation

bzabber
Copy link
Contributor

@bzabber bzabber commented Sep 30, 2023

Overview/Summary

Updated "References" for each other to include the URLs that are available in the old alertdetails.md.
Created the alerts.yaml for RecoveryVaults.

This PR fixes/adds/changes/removes

  1. Adds "References" to each alert and added URLs.

Breaking Changes

No breaking changes.

As part of this Pull Request I have

  • [ X] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [ X] Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [X ] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

…rewall, ER Circuits, ER Gateways, Azure LoadBalancer, VNET Gateways, VPN Gateways, Storage Accounts.
@bzabber
Copy link
Contributor Author

bzabber commented Sep 30, 2023

@JoeyBarnes Not sure why there's a conflict the files match.

@JoeyBarnes
Copy link
Collaborator

JoeyBarnes commented Sep 30, 2023

@bzabber - I made some changes last night that automatically seeded the alerts.yaml files with rules based on my MetricAlertRules analysis, so there was a small conflict. I have resolved it and will merge your changes.

@JoeyBarnes JoeyBarnes merged commit 87067ba into Azure:main Sep 30, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants