Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align to CAF abbreviations and project naming #22

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Align to CAF abbreviations and project naming #22

merged 8 commits into from
Oct 5, 2023

Conversation

arjenhuitema
Copy link
Contributor

@arjenhuitema arjenhuitema commented Oct 4, 2023 •
edited
Loading

Overview/Summary

Align to CAF abbreviations and project naming

This PR fixes/adds/changes/removes

  1. Updated the default value of the ALZMonitorResourceGroupName parameter to rg-amba-monitoring-001
  2. Updated the default value of the ALZMonitorResourceGroupTags paramater to amba-monitoring
  3. Documentation update to reflect the new default values.
  4. Updated the name of the Alert Processing rule to AMBA Alert Processing Rule
  5. Updated the name of the action group to AmbaActionGr

Breaking Changes

NA

Evidence

Deployment

image

Naming

image

Remediation

image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

paulgrimley
paulgrimley approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@paulgrimley paulgrimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeyBarnes JoeyBarnes merged commit 34a2832 into Azure:main Oct 5, 2023
2 of 4 checks passed
@arjenhuitema arjenhuitema deleted the namingstandard branch October 25, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgrimley paulgrimley paulgrimley approved these changes

@Brunoga-MS Brunoga-MS Awaiting requested review from Brunoga-MS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjenhuitema @paulgrimley @JoeyBarnes