Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCore - AVD Alerts v3.0 Initial Release (DRAFT) #244

Closed
wants to merge 19 commits into from

Conversation

JCoreMS
Copy link
Contributor

@JCoreMS JCoreMS commented Jun 13, 2024

Overview/Summary

Full integration with the AMBA based alerts and unhiding of the HostPool based alert criteria within the DesktopVirtualization service area.

This PR fixes/adds/changes/removes

  1. Removes Scripts and JSON with previously ported over alerts solution from AVD Accelertor
  2. Integrates AMBA based alerts for HostPool (New), VMs and Storage by reading in YAML

Breaking Changes

  1. No longer creates alerts for each host pool
  2. No longer incorporates host pool capacity related alerts (To be re-added later)

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@JoeyBarnes JoeyBarnes added the Pattern: AVD Issues / PR's related to the AVD Pattern label Jun 20, 2024
@JoeyBarnes
Copy link
Collaborator

Hey @JCoreMS - Can you check the Code Review - Linting errors. Thanks!

@JCoreMS JCoreMS changed the title JCore - AVD Alerts v3.0 Initial Release JCore - AVD Alerts v3.0 Initial Release (DRAFT) Jun 26, 2024
@JCoreMS JCoreMS marked this pull request as draft June 26, 2024 15:40
@JCoreMS JCoreMS self-assigned this Jun 28, 2024
@JCoreMS JCoreMS closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: AVD Issues / PR's related to the AVD Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants