Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issue #237. #252

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Resolve issue #237. #252

merged 3 commits into from
Jun 26, 2024

Conversation

bzabber
Copy link
Contributor

@bzabber bzabber commented Jun 21, 2024

Overview/Summary

Resolved issue #237

This PR fixes/adds/changes/removes

  1. Removes "ll" from all occurrences of "Deploy_ERP_ExpressRoutRxLightLevell_Alert" alert rule.

Breaking Changes

None

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@JoeyBarnes JoeyBarnes added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Jun 24, 2024
@arjenhuitema arjenhuitema linked an issue Jun 25, 2024 that may be closed by this pull request
[Bug]: Deploy_ERP_ExpressRoutRxLightLevell_Alert Has a Typo #237
Closed
1 task
arjenhuitema
arjenhuitema approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @bzabber

@arjenhuitema arjenhuitema merged commit fc3de79 into Azure:main Jun 26, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

Assignees
No one assigned
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Deploy_ERP_ExpressRoutRxLightLevell_Alert Has a Typo
3 participants
@bzabber @arjenhuitema @JoeyBarnes