Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCore-AVDPattern-Fix-Issue-221 #256

Merged
merged 8 commits into from
Jun 28, 2024
Merged

JCore-AVDPattern-Fix-Issue-221 #256

merged 8 commits into from
Jun 28, 2024

Conversation

JCoreMS
Copy link
Contributor

@JCoreMS JCoreMS commented Jun 28, 2024

Overview/Summary

Fixes the storage calculation script in the runbook which was yielding a much higher remaining value than truly existed. Values were in the 99.xx% range vs actual for remaining meaning the alert may never trigger when remaining storage is truly low.

This PR fixes/adds/changes/removes

resolves #221

  1. Script: Get-StorAcctInfo.ps1 line 46
    Was --- $RemainingPercent = 100 - ($shareUsageInGB / $shareQuota)
    New --- $RemainingPercent = 100 - ($shareUsageInGB / $shareQuota * 100)

Breaking Changes

  1. N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@JoeyBarnes JoeyBarnes merged commit 7e11357 into Azure:main Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question/Feedback]: AVD Pattern Storage Account Calculation in Automation Account is wrong.
2 participants