Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation #258

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Updated documentation #258

merged 4 commits into from
Jul 5, 2024

Conversation

Brunoga-MS
Copy link
Contributor

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Adds a new error message content to the existing VM Log Alert policies fail to remediate section in the Known Issue page
  2. *Adds a new section for Failed to deploy because of 'location' property not specified error in the Known Issue page
    • Adds the Switching between BYO UAMI and new UAMI ** in the Bring Your Own User Assigned Managed Identity (BYO UAMI) page*

All the above are related to the USer Story AMBA - Update Known Issues and BYO UAMI documentation

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS Brunoga-MS requested a review from arjenhuitema July 2, 2024 17:08
@arjenhuitema arjenhuitema added Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern documentation Improvements or additions to documentation labels Jul 2, 2024
@arjenhuitema arjenhuitema self-assigned this Jul 2, 2024
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Brunoga-MS, few comments, can you review? After that we should be good the merge!

Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arjenhuitema arjenhuitema merged commit dd5076a into Azure:main Jul 5, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants