Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALZ Pattern Update #317

Merged
merged 454 commits into from
Sep 2, 2024
Merged

ALZ Pattern Update #317

merged 454 commits into from
Sep 2, 2024

Conversation

arjenhuitema
Copy link
Contributor

Overview/Summary

We have recently introduced several exciting updates to Azure Monitor Baseline Alerts (AMBA) for Azure Landing Zones (ALZ). These updates are designed to provide a more modular, flexible, and comprehensive monitoring experience.

This PR fixes/adds/changes/removes

  1. Introducing the AMBA Portal Accelerator (Preview)
  2. Modular Approach to Initiatives
  3. New Alert Rules
  4. Threshold Override
  5. Custom tags and values to disable monitoring
  6. resolves Can we add a Parameter to adjust "Number of Violations"  #177
  7. resolves [Question/Feedback]: Is it possible to add Alerts for type: Microsoft.KeyVault/managedHSMs in Identity initiative ? #195
  8. resolves [Question/Feedback]: Using Custom tags to enable/disable monitoring #198
  9. resolves Unable to Exclude Virtual Machine Scale Sets Using the MonitorDisable tag #206
  10. resolves [Feature Request]: Add alert for data limited reached for Log Analytics workspaces #213
  11. resolves [Question/Feedback]: Deploying AMBA #253
  12. resolves Feedback: No treshold parameter for ALZ alerts #260
  13. resolves [Question/Feedback]: displayname VMLowOSDisk(Write/Read)LatencyAlert should be VMHighOSDisk(Write/Read)LatencyAlert #261
  14. resolves [Question]: How to override the default alert threshold values for specific resource names? #272
  15. resolves [Bug]: Deploy VNetG ExpressRoute CPU Utilization Alert remediation fails #278
  16. resolves [Bug]: AGW Compute Units Alert and AGW Unhealthy Host Count Alert remain non-compliant after successful remediation #280
  17. resolves AMBA policy ALZ_ServiceHealth_ActionGroups Missing when remediating AMBA policies - Bug Report #284

Breaking Changes

  1. Parameter type changes from string to array
  2. Updated paramaters for Custom tags and values to disable monitoring
  3. Landing Zones Initiative has been deprecated and replaced for new resource based initiatives.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Brunoga-MS and others added 30 commits July 2, 2024 21:26
…T5M as the default value for evaluationFrequency
…T5M as the default value for evaluationFrequency
…1D as the default value for evaluationFrequency
Alert for daily data capping limit reached for Log Analytics workspaces
Fixing latency alert display name
Fixed alert storm and default values for daily cap alert
Added/updated Compute/virtualMachines
refactor: Update query for VM heartbeat alert criteria
@arjenhuitema arjenhuitema added enhancement New feature or request Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern labels Aug 30, 2024
@arjenhuitema arjenhuitema self-assigned this Aug 30, 2024
Brunoga-MS
Brunoga-MS previously approved these changes Aug 30, 2024
Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed the AppInsights alert from the table since we are not releasing it with this release.
Based on previous testing and random checks on files this one LGTM.

Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit 4aea188 into main Sep 2, 2024
3 of 5 checks passed
@arjenhuitema arjenhuitema deleted the dev-alz-pattern branch September 2, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment