Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting how to modify individual policies #34

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

Brunoga-MS
Copy link
Contributor

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

- Documenting individual policy change process
- Aligning documentation for multiple email addresses
- Fixing typos on:
  - _index.md
  - Customize-Policy-Assignment.md
  - Introduction-to-deploying-the-ALZ-pattern.md
- Fixing ALZMonitorResourceGroupTags value in the parameter file
- Removing the customization of ALZMonitorResourceGroupTags
Aligning documentation for multiple email addresses
Fixing typos on:
_index.md
Customize-Policy-Assignment.md related to [Question/Feedback]: Modifying policy definitions clarification Azure#24 and workitem GH#24 AMBA: Clarification for modifying individual policies
Introduction-to-deploying-the-ALZ-pattern.md
Fixing ALZMonitorResourceGroupTags value in the parameter file
Removing the customization of ALZMonitorResourceGroupTags
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Bruno. Let's park the tagging discussion untill Friday and get the other items in with this PR.

Copy link
Contributor Author

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments addressed

patterns/alz/alzArm.param.json Outdated Show resolved Hide resolved
patterns/alz/alzArm.param.json Outdated Show resolved Hide resolved
docs/content/patterns/alz/deploy/Deploy-with-Azure-CLI.md Outdated Show resolved Hide resolved
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema added the documentation Improvements or additions to documentation label Oct 10, 2023
@arjenhuitema arjenhuitema linked an issue Oct 10, 2023 that may be closed by this pull request
1 task
@arjenhuitema arjenhuitema merged commit 422f9df into Azure:main Oct 10, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question/Feedback]: Modifying policy definitions clarification
2 participants