Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useCommonSchema to useCommonAlertSchema in Deploy_ServiceHealth_ActionGroups and Deploy_Suppression_AlertProcessing_Rule Policy Definitions #346

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

haflidif
Copy link
Contributor

@haflidif haflidif commented Sep 24, 2024

Overview/Summary

This PR updates wrong variables for enabling use of Common Alert Schema for LogicApp, EmailRecievers and ARMRoleRecievers as in:

Update useCommonSchema to useCommonAlertSchema in
Deploy_ServiceHealth_ActionGroups and Deploy_Suppression_AlertProcessing_Rule Policy Definitions

This PR fixes/adds/changes/removes

  1. fixes [Bug]: Wrong variables for Enable Common Alert Schema in Policy Definition Deploy_ServiceHealth_ActionGroups and Deploy_Suppression_AlertProcessing_Rule #345

Breaking Changes

  1. There should not be any breaking changes here, only a fuctional ARM Templates that are being deployed instead of non functioning arm templates when these services are being used for sending notifications alerts.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

…iceHealth_ActionGroups` and `Deploy_Suppression_AlertProcessing_Rule` Policy Definitions
@arjenhuitema arjenhuitema added bug Something isn't working Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Sep 27, 2024
@arjenhuitema
Copy link
Contributor

Hi @haflidif, thank you for the feedback and for submitting the PR; it's much appreciated.

@ymehdimsft, you have been assigned a story for this sprint to tackle this issue. Could you please review the changes in this PR and compare them with your story?

@arjenhuitema arjenhuitema self-assigned this Oct 1, 2024
@arjenhuitema arjenhuitema reopened this Oct 2, 2024
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @haflidif, thank you for reporting this and providing the solution. It is much appreciated.

@arjenhuitema arjenhuitema merged commit 04f8ff2 into Azure:main Oct 2, 2024
1 check passed
@Dikkekip
Copy link

Dikkekip commented Oct 2, 2024

Nice one @haflidif !

@haflidif haflidif deleted the issue-345 branch October 7, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy bug Something isn't working Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
3 participants